Skip to content

handle svg2png rendering error more gracefully #11111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2024
Merged

handle svg2png rendering error more gracefully #11111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/resources/extensions/quarto/placeholder/placeholder.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,24 @@ return {
local svg64 = "data:image/svg+xml;base64," .. quarto.base64.encode(svg)
local result

if kwargs["format"] == "svg" then
local output_format = pandoc.utils.stringify(kwargs["format"])
if output_format == "" then
if quarto.format.is_typst_output() then
output_format = "svg"
else
output_format = "png"
end
end

if output_format == "svg" then
result = svg64
else
local mt, contents = pandoc.mediabag.fetch("https://svg2png.deno.dev/" .. svg64)
if mt ~= "image/png" then
error("Expected image/png but got " .. mt)
error(contents)
return pandoc.Str("Error rendering placeholder")
end
result = "data:" .. mt .. ";base64," .. quarto.base64.encode(contents)
end

Expand Down
Loading