Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/changelog-1.6.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ All changes included in 1.6:
- ([#6012](https://github.com/quarto-dev/quarto-cli/issues/6012)): Add styling for `kbd` element in Revealjs slides.
- ([#10887](https://github.com/quarto-dev/quarto-cli/issues/10887)): Updating default Mathjax used from 2.7.0 to 2.7.9.
- ([#9999](https://github.com/quarto-dev/quarto-cli/issues/9999)): Fix spacing problems of different size elements in columns.
- ([#11146](https://github.com/quarto-dev/quarto-cli/issues/11146)): Fix issue with slide created with `---` and having no title showing up in TOC. Now they don't show up as slide created with empty header e.g. `## `.

## `typst` Format

Expand Down
6 changes: 3 additions & 3 deletions src/format/reveal/format-reveal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ export function revealjsFormat() {
const determineRevealLogo = (format: Format): string | undefined => {
const brandData = format.render.brand?.processedData;
if (brandData?.logo) {
const keys: ("medium" | "small" | "large")[] = ["medium", "small", "large"]
const keys: ("medium" | "small" | "large")[] = ["medium", "small", "large"];
// add slide logo if we have one
for (const size of keys) {
const logoInfo = brandData.logo[size];
Expand Down Expand Up @@ -582,12 +582,12 @@ const handleInvisibleSlides = (doc: Document) => {
const handleUntitledSlidesInToc = (doc: Document) => {
// remove from toc all slides that have no title
const tocEntries = Array.from(doc.querySelectorAll(
'nav[role="doc-toc"] a[href^="#/"]',
'nav[role="doc-toc"] ul > li',
));
for (const tocEntry of tocEntries) {
const tocEntryEl = tocEntry as Element;
if (tocEntryEl.textContent.trim() === "") {
tocEntryEl.parentElement?.remove();
tocEntryEl.remove();
}
}
};
Expand Down
29 changes: 29 additions & 0 deletions tests/docs/smoke-all/2024/10/22/11146.qmd
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
---
format: revealjs
toc: true
_quarto:
tests:
revealjs:
ensureHtmlElements:
-
- 'nav[role="doc-toc"] ul > li:nth-child(1) > a[href$="section-1"]'
- 'nav[role="doc-toc"] ul > li:nth-child(2) > a[href$="section-2"]'
-
- 'nav[role="doc-toc"] ul > li:nth-child(3)'
---

## Section 1

Should show up in the TOC as a bullet point.

---

No title and should not be

## Section 2

Should show up in the TOC as a bullet point.

##

No title and should not be in the TOC
Loading