Better Handle new chrome #11187
Merged
Better Handle new chrome #11187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome v128 changed the default from --headless=old to --headless=new in 2024-08. Old headless mode was effectively a separate browser render, and while more performant did not share the same browser implementation as headful Chrome. New headless mode will likely be useful to some, but in Quarto use cases like printing to PDF or screenshoting, we need more work to move to the new mode. We'll use `--headless=old` as the default for now until the new mode is more stable, or until we really pin a version as default to be used. This is also impacting in chromote and pagedown R packages and we could keep syncing with them.
…QUARTO_CHROMIUM` closes #10170
[skip ci]
This was referenced Oct 25, 2024
|
It appears the new |
This was referenced Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New headless mode in chrome
Chrome has new headless mode (https://developer.chrome.com/docs/chromium/headless) activated as default since v128. This PR set back to
--headless=oldto revert back to old mode we know is working ok. There is a newQUARTO_CHROMIUM_HEADLESS_MODEenv var to configure this. This is to fix #11135.Tested with
This now renders ok under this PR.
If
QUARTO_CHROMIUM_HEADLESS_MODE=newis set and a chrome browser is already opened. Then #11135 will reproduce. close any browser open and keepQUARTO_CHROMIUM_HEADLESS_MODE=new, and issue disappear. So definitely some adaptations to make for new headless mode. As long as we can use,oldthen we can wait.Avoid blocking problem by allowing selecting the chromium binary to use
This PR introduce also a new
QUARTO_CHROMIUMto specify which binary to use and not let Quarto detection applies. closes #10170 (which closes #2980 and closes #4648)Currently I am testing our bundled
quarto install chromiumversion to see if this still work and if it is ok with this change. This is quite an old pinned version.Also, I noticed on windows that chrome opened for screenshot does not close... So investigating that too.