Correctly overwrite _reboot.scss to not apply font-size twice #11198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows up on #11028 to do it differently in similar manner as in `_reboot.scss` so that code inside pre does not apply font-size a second time
add a test with playwright to check that we don't modify code fontsize in a way that this is will get a different value for code inside pre than font-size of pre itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up on #11028 to do it differently in similar manner as in
_reboot.scssso that code inside pre does not apply font-size a second timecloses #11185
I decided that other issue I found with
$code-font-sizebeing change and how code-annotation behave will be done in 1.7 in another issue. Let's just fix for now what was working in 1.5 and no more in 1.6.No changelog item because it is fixing a problem from one of the 1.6 new feature.
I think I'll add a test using playwright about this code font size default change which was the problem for the annotation. Then I'll merge