Update shebang in postBuild script to use 'env -S' for bash with verbose flag #11214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ose flag On many systems, `env` does not work when bash is given a flag. `-S` ensures that the flag is passed to bash on all systems. This should fix a bug at least I was getting when trying to build binder images.
she3o
changed the title
|
Can you remove all other lines from this PR except the |
she3o
force-pushed
the
postBuild-improvements
branch
from
0e546f5 to
d5925ae
Compare
|
Thank you! (FYI The other refactoring changes are fine, but they get to the point where we'd need you to sign our CLA). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #11213