Skip to content

Loosen image auto-discovery for OpenGraph #11226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 28, 2024
Merged

Loosen image auto-discovery for OpenGraph #11226

merged 5 commits into from
Oct 28, 2024

Conversation

cscheid
Copy link
Collaborator

@cscheid cscheid commented Oct 28, 2024

Closes #10311.

@cscheid
Copy link
Collaborator Author

cscheid commented Oct 28, 2024

Note that this PR reverts the change that was made to fix #5625 because we now place footers outside the page's main content, and so "loose" auto-discovery works fine.

In order to make sure we don't regress, I've added an additional test that exercises the issue in #5625.

@cscheid cscheid merged commit cf4e951 into main Oct 28, 2024
47 checks passed
@cscheid cscheid deleted the bugfix/10311 branch October 28, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Opengraph preview not created automatically from a python-generated cell output image?

1 participant

@cscheid