Skip to content

Conversation

gordonwoodhull
Copy link
Contributor

This allows

:::{style="background-color: var(--brand-dark-grey); color: var(--brand-blue)"}
This div is blue on dark grey.
:::

producing

#block(fill: brand-color.dark-grey)[
#set text(fill: brand-color.blue); This div is blue on dark grey.

]

or produces a warning if the named brand color does not exist.

Parsing variable references isn't worse than parsing rgb, right?

cc @cwickham

@gordonwoodhull
Copy link
Contributor Author

gordonwoodhull commented Nov 1, 2024

Odd, this test

tests/docs/smoke-all/2024/10/28/brand-typography-family-string

from Monday a97fcc0 was just failing today, get_typography in brand.lua needs to upgrade family string to typography object.

I don't understand how this change opens up that code path, but apparently it does.

@gordonwoodhull gordonwoodhull merged commit f0b3715 into main Nov 4, 2024
47 checks passed
@gordonwoodhull gordonwoodhull deleted the feature/div-colors-brand-css-colors branch November 4, 2024 15:04
gordonwoodhull added a commit to quarto-dev/quarto-web that referenced this pull request Nov 4, 2024
gordonwoodhull added a commit to quarto-dev/quarto-web that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant