Skip to content

forward link variables to SCSS #11281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2024
Merged

forward link variables to SCSS #11281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
208d249
forward link variables to SCSS
cscheid Nov 1, 2024
fdbe180
add missing default
cscheid Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/core/sass/brand.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,7 @@ const brandTypographyBundle = (
"style",
"color",
"background-color",
"decoration",
]
) {
// deno-lint-ignore no-explicit-any
Expand Down Expand Up @@ -447,6 +448,13 @@ const brandTypographyBundle = (
["color", "presentation-heading-color"],
// TODO: style, needs CSS change
],
"link": [
// bootstrap + revealjs
["color", "link-color"],
["background-color", "link-color-bg"],
["weight", "link-weight"],
["decoration", "link-decoration"],
],
"monospace": [
// bootstrap + revealjs
["family", "font-family-monospace"],
Expand Down Expand Up @@ -497,6 +505,7 @@ const brandTypographyBundle = (
for (
const kind of [
// more specific entries go first
"link",
"monospace-block",
"monospace-inline",
"monospace",
Expand Down
7 changes: 7 additions & 0 deletions src/resources/formats/html/bootstrap/_bootstrap-rules.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2174,3 +2174,10 @@ code {
@include font-size($code-inline-font-size);
font-weight: $font-weight-monospace-inline;
}

// link styling
a {
background-color: $link-color-bg;
font-weight: $link-weight;
text-decoration: $link-decoration;
}
6 changes: 5 additions & 1 deletion src/resources/formats/html/bootstrap/_bootstrap-variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ $link-color: if(
theme-override-value($theme-name, "link-color", $link-color),
$link-color
);
$link-color-bg: transparent !default;

/* Code Block Formatting */
// Code Block Border Treatment
Expand Down Expand Up @@ -255,7 +256,8 @@ $h1h2h3-font-weight: 600 !default;
$font-weight-base: 400 !default;
$small-font-size: 0.875em !default;
$code-font-size: $small-font-size !default;
$font-family-monospace: SFMono-Regular, Menlo, Monaco, Consolas, "Liberation Mono", "Courier New", monospace !default;
$font-family-monospace: SFMono-Regular, Menlo, Monaco, Consolas,
"Liberation Mono", "Courier New", monospace !default;

$font-family-monospace-block: $font-family-monospace !default;
$font-family-monospace-inline: $font-family-monospace !default;
Expand All @@ -264,3 +266,5 @@ $font-weight-monospace-block: $font-weight-monospace !default;
$font-weight-monospace-inline: $font-weight-monospace !default;
$code-block-font-size: $code-font-size !default;
$code-inline-font-size: $code-font-size !default;
$link-weight: $font-weight-base !default;
$link-decoration: inherit !default;
11 changes: 11 additions & 0 deletions src/resources/formats/revealjs/quarto.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ $font-weight-base: 400 !default;
$code-font-size: $presentation-font-size-root !default;
$font-family-monospace-block: $font-family-monospace !default;
$font-family-monospace-inline: $font-family-monospace !default;
$link-weight: $font-weight-base !default;
$link-color-bg: transparent !default;
$link-decoration: inherit !default;

// main colors
$body-bg: #fff !default;
Expand Down Expand Up @@ -923,3 +926,11 @@ kbd {
--r-inline-code-font-size: #{$revealjs-code-inline-font-size};
--r-block-code-font-size: #{$revealjs-code-block-font-size};
}

// _brand.yml rules

.reveal a {
font-weight: $link-weight;
background-color: $link-color-bg;
text-decoration: $link-decoration;
}
Loading