-
Notifications
You must be signed in to change notification settings - Fork 383
Add QUARTO_KNITR_RSCRIPT_ARGS to pass some flags to RScript for knitr engine #11337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
to pass some flags to Rscript run by Quarto for knitr engine. This can be useful in specific situation like e.g `--max-connections=258` available in R 4.4, or `--vanilla` Args should be passed a comma separated list of flags. This is for expert use and there is not check done on the argument being support by RScript or not.
fdffa57
to
c64046a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting environment variables like this is risky - environment variables are global options and we can have tests running in parallel. In that case, the environment variables might end up being changed for tests other than this one.
You mean for the added feature or for the test only ? For the feature it seems ok to do it like this, as we discussed. Did you have another solution in mind ? I assume you are talking about the tests.
I discovered that working on other tests this week where I wanted to use But from your comment I assume I am wrong. I understand now that we can't really do this at all because I did it initially in #11245 some time ago but discovered this week the possible drawback trying to using Does this mean can't test anything that really on environment variable setting because of asynchronous behavior and that everything works in same environment ? To understand if I should just remove the test or try to adapt somehow... |
Yes, that's what I was talking about. |
So let's just remove those tests then. I didn't find a great way to tweak environment variable for a single test only. |
They could be added back as part of tests that we run with bundled versions. We know we need to run some already. Or something I did not try... leveraging Quarto project and |
2c2eb74
to
4007a9d
Compare
e.g
--max-connections=258
available in R 4.4, or--vanilla
Args should be passed a comma separated list of flags.
This is for expert use and there is not check done on the argument being support by RScript or not.