Skip to content

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Nov 9, 2024

Description

This PR moves a few method calls that were deprecated and removed in Deno 2 to their replacements (except for Deno.metrics(), which was removed without replacement).

This is not a complete set of changes: some dependencies also need to be updated or patched (xmlp is the main one that I'm aware of right now), but testing the waters here with this smaller and simpler one since this is my first contribution.

Checklist

I have (if applicable):

  • filed a contributor agreement.
  • referenced the GitHub issue this PR closes
  • updated the appropriate changelog in the PR
  • ensured the present test suite passes
  • added new tests
  • created a separate documentation PR in Quarto's website repo and linked it to this PR

@tjni
Copy link
Contributor Author

tjni commented Nov 9, 2024

Regarding the contributor agreement form, what goes in the "fascimile" field?

@cscheid
Copy link
Collaborator

cscheid commented Nov 15, 2024

Regarding the contributor agreement form, what goes in the "fascimile" field?

A fax number if your company has one - no entry otherwise.

@cscheid cscheid added this to the v1.7 milestone Nov 18, 2024
@tjni
Copy link
Contributor Author

tjni commented Dec 2, 2024

I sent over my signed contributor agreement form. Sorry for the delay.

@cscheid
Copy link
Collaborator

cscheid commented Dec 2, 2024

Thanks. Can you comment on the Deno.metrics() change?

@tjni
Copy link
Contributor Author

tjni commented Dec 2, 2024

Sure. As far as I can tell, it was removed without replacement in Deno 2 and first deprecated by denoland/deno#20684. It sounds like maintaining it was deemed too difficult. Beyond that, I don't have any more information.

@cscheid
Copy link
Collaborator

cscheid commented Dec 2, 2024

That's unfortunate - we were using that to check for stray unresolved promises.

Ok, this looks good, thanks.

@cscheid cscheid merged commit e20d78d into quarto-dev:main Dec 2, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants