revealjs - set code-font-size as em value for variable default #11376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11373 by adapting previous changes in #11028 and then #11237. The changes initially introduced for Brands were making code font size default being pixels, while previous is was set to
em
and so code font size was adapting based on context like headers.This PR is making code font size being based on
em
like Quarto 1.5 while keeping the customizable values. Defaults are chosen like this$code-font-size
in Revealjs isem
units by default which seems more coherent with its bootstrap counter part, also asem
. Value is1em
for revealjs.$code-block-font-size
is set to 0.55em - same as previous Revealjs default, smaller than bootstrap to save some slide space.$code-inline-font-size
is set to 0.875em - same as bootstrapThis also simplifies previous logic with smaller context (like callout or smaller slides), and so previous adaptation from previous followed up PR are removed (and test adapted).
I believe this is closer to default RevealJS and previous Quarto 1.5 style, while keeping the
$code-font-size
And it is probably better for brand for
size
being passed tocode-font-size
in same units for revealjs and bootstrap.Quarto example has been updated with this PR