feat: Save .scss file before and after compilation if QUARTO_SAVE_SCSS is set #11450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscheid
reviewed
Nov 15, 2024
|
I think this is good. But let me ask: were you having trouble with a file that failed to compile between the two steps? The process that adds the css vars block goes through a third-party parser that is not as robust as I'd prefer, and I'd like to see the failures! |
For posterity: the compilation issue was the result of using a variable before it was defined. So not a result of the parser but a legitimate Sass compilation issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
QUARTO_SAVE_SCSS=<prefix>allows users to save the intermediate Sass files used by Quarto for debugging purposes, but the file is currently written after a compilation step that may fail.This PR changes the process to save the Sass file before compilation and then overwrite it after the compilation step with the additional
--quarto-scss-export-variables added in.