Reduce implicit type conversions in Lua #11525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarleb
force-pushed
the
avoid-implicit-type-conversions
branch
7 times, most recently
from
56c1d73 to
6fe2889
Compare
3 tasks
tarleb
force-pushed
the
avoid-implicit-type-conversions
branch
2 times, most recently
from
587eaf5 to
3a23485
Compare
tarleb
force-pushed
the
avoid-implicit-type-conversions
branch
from
3a23485 to
864b2c7
Compare
Minor performance improvement.
This allows to get reproducible output when running the filter multiple times.
If the metadata object is modified in a filter, then it should be returned, as otherwise the changes might be lost. In the given case, the return wasn't necessary, because filters that act only on `Meta` objects are handled specially, in that the filter function is called directly, without doing an actual traversal via `walk`. However, this can lead to unexpected bugs; explicitly returning the modified Meta object is cleaner and more robust.
The `long` field of a caption can never be nil, but it can be an empty list.
The `blocks` property of a Pandoc object should always contain an object of type `Blocks`.
tarleb
force-pushed
the
avoid-implicit-type-conversions
branch
from
864b2c7 to
3a0dc9e
Compare
|
This was discussed and approved out of band, so I'm merging it. |
|
Thank you! This is very exciting. |
This was referenced Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduces the amount of implicit type conversions that happens during unmarshalling from Lua. This makes it safer to re-use pandoc AST elements without looping them through pandoc/Haskell.