Allow to check for mis-typed attributes and accidental AST changes #11538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
tarleb
force-pushed
the
attribute-checks
branch
from
989db8d to
7ccd068
Compare
tarleb
force-pushed
the
attribute-checks
branch
from
7ccd068 to
010c7ad
Compare
cscheid
reviewed
Dec 12, 2024
cscheid
approved these changes
Dec 12, 2024
cscheid
approved these changes
Jan 17, 2025
Collaborator
|
@tarleb There's a conflict here that I think you're better equipped to merge than I am. When that's sorted out, feel free to merge 🚀 |
Setting the `QUARTO_JOG_CHECK` environment variable will run checks to identify element attributes that have the wrong type, and will also find filters that modify the input object, but don't return it. Both of these can cause issues with jog.
Collaborator
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Collaborator
Author
|
@cscheid would you do another quick review? I moved code around a little and ended up adding two global table functions. |
Collaborator
|
This looks like a good implementation. It would be helpful to have a document with a known-bad filter, which we want to see fail, and a test that verifies that it indeed fails. We don't have "expect-fail" functionality in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the
QUARTO_JOG_CHECKenvironment variable will run checks to identify element attributes that have the wrong type, and will also find filters that modify the input object, but don't return it. Both of these can cause issues when switching to a different traversal method.