Re-enable change to markdown highlighting from previous quarto version #11643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixing all the highlighting issue in markdown block and adds some improvement.
For the context, quarto embeds a
markdown.xml
that is tweaked to support special quarto syntax for computation code block. However, the tweaked file was overwritten in c47753c while updatingmarkdown.xml
from upstream.So this PR first re-enable everything:
All this was lost several Quarto version ago, and we did not notice while our website lost its highligting for julia, ojs and diagram example. 🤦
This PR also adds some better support for
julia
anddot
which are both supported language by skylighting already. So themarkdown.xml
is further customized so that it defer to those language highlighting for embedded code block.This fixes part of #1453 as now
dot
will correctly be highlighed.For
mermaid
, it will require creating or finding amermaid.xml
as KDE doesn't have one.This PR also add tests so that we don't break this again.