Skip to content

Conversation

@gordonwoodhull
Copy link
Contributor

@gordonwoodhull gordonwoodhull commented Dec 11, 2024

fixes #11578
replaces #11579

Use fraction units for any defaulted or unitless column layout widths, because percent unit seems to use the percentage of the page.

I know we usually try to keep format-specific stuff out of the early filters, but the truth is that width units are not format-independent: we just assume that any widths specified are valid.

And we need to use fr and not % units for defaulted or unitless column widths for Typst.

::: {layout="[1, 2, 2, 1, 3, 1, 1]"}
image
::: {layout-ncol=5}
image
::: {layout-ncol=5}

and third image has {width=100pt}
image

cc @mcanouil

@cscheid
Copy link
Collaborator

cscheid commented Dec 11, 2024

I know we usually try to keep format-specific stuff out of the early filters

That's true and your reasoning would be good enough to justify the change. But layout filters are called in post-quarto exactly because of what you're saying: layouts cannot really be format-agnostic.

@cscheid
Copy link
Collaborator

cscheid commented Dec 11, 2024

Looks great! I think all we're missing here is a changelog entry.

@gordonwoodhull gordonwoodhull merged commit a767def into main Dec 11, 2024
47 checks passed
@gordonwoodhull gordonwoodhull deleted the bugfix/11578 branch December 11, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Charts in Callout Boxes Overflow Their Boundaries in Typst Format

3 participants