chrome - change back to --headless as default.
#11885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And keep option to set it to old for QUARTO_CHROMIUM specified version
|
@cscheid it seems this is impacted a number of users using 1.6.40 and current fix is to make them install latest 1.7 I am thinking of backporting this change - it does not seem to much trouble as this is just a change of default to adapt to newer chrome. would that be ok for you ? (and we should make a patch release for february as there are other backport there already) |
cderv
added a commit
that referenced
this pull request
Feb 13, 2025
chrome - change back to `--headless` as default. This should prevent further problem with recent Chrome and current Quarto 1.6 release
cderv
added a commit
that referenced
this pull request
Feb 13, 2025
chrome - change back to `--headless` as default. This should prevent further problem with recent Chrome and current Quarto 1.6 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And keep option to set it to old for QUARTO_CHROMIUM specified version
This is a quick fix so that our current pre-release version do work with chrome past and present.
This will use the default
--headlessmode available on the chrome binary used. Starting with chrome 112, it means this will be new headless mode (https://developer.chrome.com/docs/chromium/headless)chrome headless shell can also be set with
QUARTO_CHROMIUMand will work with thisThis is the easist fix for now, and it seems to work for me (which new headless had problem on Windows before).
I think the safest for Quarto will be to allow installing
chrome-headless-modeand use that.