-
Notifications
You must be signed in to change notification settings - Fork 383
fix: \f
form feed character ({{< pagebreak >}}
) not valid in PowerPoint (pptx
)
#11896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 18 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
f13afd3
fix: pagebreak breaks PowerPoint
mcanouil b33d991
chore: Update changelog-1.7.md
mcanouil 0e32ad9
fix: typo
mcanouil 3ec28da
fix: missing closing parenthesis
mcanouil b75b3f7
chore: Update changelog-1.7.md
mcanouil c1fa9e6
chore: mention pagebreak shortcode in item
mcanouil 900b34c
chore: capital letter missing
mcanouil 4b81322
fix: return empty element as suggested
mcanouil e0bb444
Merge branch 'main' into fix/issue11893
mcanouil e1b5a49
Merge branch 'main' into fix/issue11893
mcanouil bb28437
test: check content and slide number
mcanouil 215b5f1
test: there is 1 not 2 slides
mcanouil 8f9d5b5
test: tweak test
mcanouil 19c3105
test: set 2 slides with no pattern for the first
mcanouil 64adb1d
test: try without title slide
mcanouil 9bdf587
test: rm double /
mcanouil fae793d
test: try regex instead (no escaping)
mcanouil 798a820
test: escaping /
mcanouil 949d405
test: set slide number
mcanouil dcb00f5
Merge branch 'main' into fix/issue11893
mcanouil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
--- | ||
format: pptx | ||
_quarto: | ||
tests: | ||
pptx: | ||
ensurePptxMaxSlides: | ||
- 1 | ||
ensurePptxRegexMatches: | ||
- '<a:t>Before<\/a:t><\/a:r><\/a:p><a:p><a:pPr lvl="0" indent="0" marL="0"><a:buNone \/><\/a:pPr><a:r><a:rPr \/><a:t>After<\/a:t>' | ||
--- | ||
|
||
## Slide | ||
|
||
Before | ||
|
||
{{< pagebreak >}} | ||
|
||
After |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.