Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12159 (in a more general way).
Addresses #11487
Example:
Collate dark brand in brand sass bundles and use it for creating dark sass bundles.
resolveBrandnow returns{light?:, dark?:}, basic downstream changes have been made.1 May need adjustment.Enable toggling when brand is multi and includes dark (as previously for theme).
Includes some smoke tests; probably some edge cases need to be tested further.
Footnotes
e.g. to still use
.lightfor all the places we are pulling logo. No attempt yet to apply dark logo where needed: that would be a separate effort. ↩