Skip to content

Conversation

@gordonwoodhull
Copy link
Contributor

@gordonwoodhull gordonwoodhull commented Mar 18, 2025

Fixes #12159 (in a more general way).

Addresses #11487

Example:

brand:
  dark: dark-brand.yml
  light: light-brand.yml

Collate dark brand in brand sass bundles and use it for creating dark sass bundles.

resolveBrand now returns {light?:, dark?:}, basic downstream changes have been made.1 May need adjustment.

Enable toggling when brand is multi and includes dark (as previously for theme).

Includes some smoke tests; probably some edge cases need to be tested further.

Footnotes

  1. e.g. to still use .light for all the places we are pulling logo. No attempt yet to apply dark logo where needed: that would be a separate effort.

@gordonwoodhull gordonwoodhull marked this pull request as ready for review March 18, 2025 23:59
@gordonwoodhull gordonwoodhull marked this pull request as draft March 21, 2025 19:00
@gordonwoodhull gordonwoodhull marked this pull request as ready for review March 22, 2025 17:10
@gordonwoodhull
Copy link
Contributor Author

gordonwoodhull commented Mar 22, 2025

Properly collates dark and light bundles, including interaction with themes.

E.g. to use light and dark themes but have dark and light brand.yml override them, use

theme:
  dark: [dark-theme, brand]
  light: [light-theme, brand]

Next steps

Will file PRs for these separately.

enable dark brand in brand sass bundles; do not exempt brand when creating dark sass bundles

enable toggling when brand is multi and includes dark
(as previously for theme)
@gordonwoodhull gordonwoodhull marked this pull request as draft March 22, 2025 17:46
@gordonwoodhull gordonwoodhull marked this pull request as ready for review March 23, 2025 17:15
@gordonwoodhull gordonwoodhull merged commit 76d6f83 into main Mar 23, 2025
49 checks passed
@gordonwoodhull gordonwoodhull deleted the feature/dark-brand branch March 23, 2025 17:35
gordonwoodhull added a commit that referenced this pull request Mar 24, 2025
gordonwoodhull added a commit that referenced this pull request Mar 24, 2025
for #12319 and (to a lesser degree) #12173
testing theme/brand integration and dark brand
gordonwoodhull added a commit that referenced this pull request Mar 24, 2025
for #12319

testing theme/brand integration and dark brand

also includes NoJS tests for #12173
gordonwoodhull added a commit that referenced this pull request Mar 24, 2025
for #12319

testing theme/brand integration and dark brand

also includes NoJS tests for #12173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dark mode and brand yml

2 participants