brand short code light dark test for #12365 #12437
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adding a test and changelog for a shortcode api change.
#12365 was not a pure refactor; it did introduce an optional second parameter to the brand color shortcode
{{< brand color blue dark >}}At shortcode time there is no user preference, so it defaults to
light. 1I'll need to document this as well.
Footnotes
There could be author preference but I don't know if that's helpful — in an html context you will need to use both light and dark brand colors to create something that is mindful of both modes. This is an argument for making
brandModethe first parameter, but I didn't want to break existing documents. ↩