Skip to content

Conversation

@gordonwoodhull
Copy link
Contributor

@gordonwoodhull gordonwoodhull commented Apr 2, 2025

Just adding a test and changelog for a shortcode api change.

#12365 was not a pure refactor; it did introduce an optional second parameter to the brand color shortcode

{{< brand color blue dark >}}

At shortcode time there is no user preference, so it defaults to light. 1

I'll need to document this as well.

Footnotes

  1. There could be author preference but I don't know if that's helpful — in an html context you will need to use both light and dark brand colors to create something that is mindful of both modes. This is an argument for making brandMode the first parameter, but I didn't want to break existing documents.

this was not a pure refactor; it did introduce another parameter to the brand color shortcode
at shortcode time there is no user or auther preference, this just defaults to light
@gordonwoodhull gordonwoodhull merged commit 3b7d6ec into main Apr 2, 2025
49 checks passed
@gordonwoodhull gordonwoodhull deleted the test/shortcode-light-dark-brand branch April 2, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants