Skip to content

Conversation

gordonwoodhull
Copy link
Contributor

@gordonwoodhull gordonwoodhull commented Apr 14, 2025

This is an alternative to #12523

It also fixes the highlight style bleed issues, but it fixes the big dark mode syntax highlighting bug a different way, by disabling the light highlight stylesheet when in dark mode.

This is arguably simpler, but it's not how our highlight stylesheets worked in 1.6, where dark = light + dark for highlight stylesheets as well. So it is less conservative.

Although I could detect no difference in dark mode syntax highlighting between the two PRs, and the other has uglier code, I favor the other one.

fixes #12399
fixes #12522

these test some elements we saw bad behavior in nojs mode

also, a rather more severe bug where light highlighting is being applied
these more specific and bad highlight styles bleed through from dark to light mode

fixes #12399
fixes #12522
@gordonwoodhull
Copy link
Contributor Author

Closed in favor of #12523

@gordonwoodhull gordonwoodhull deleted the bugfix/disable-light-highlight branch April 15, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant