light/dark toggle: fire window resize event #12625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
gordonwoodhull
added
the
themes
gordonwoodhull
force-pushed
the
bugfix/light-dark-toggle-resize
branch
from
4915616 to
a468852
Compare
fixes sizing issues in plotly-python and heatmaply fixes non-displaying leaflet
gordonwoodhull
force-pushed
the
bugfix/light-dark-toggle-resize
branch
from
a468852 to
f71e06f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport PR for v1.7
The light/dark toggle is now hiding and showing all of the plots and tables via
.light-content,.dark-content. Some of these plots and tables may be widgets which need to check their size.Technique found in
ShinyResizeObserver: fire a resize event on the window.This fixes sizing issues in plotly-python1 and heatmaply, and it fixes leaflet not displaying when toggling between light and dark modes.
Footnotes
plotly-python jitters on first toggle ↩