Skip to content

Conversation

@cderv
Copy link
Collaborator

@cderv cderv commented May 5, 2025

This is a new PR for #12446

This PR complements the one for R

Ruff VSCODE extension is now configuredto format all *.py

*.ipynb are skipped because of #| to # | change for cell options.

configuration is done on .ruff.toml so that ruff works on CLI too.

@cderv cderv added this to the v1.8 milestone May 5, 2025
@posit-snyk-bot
Copy link
Collaborator

posit-snyk-bot commented May 5, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@cscheid
Copy link
Collaborator

cscheid commented May 5, 2025

(Your PR didn't actually change src/resources/jupyter/lang/python/setup.py, but we need to be aware that this file isn't by itself valid Python syntax. Ideally we'd stop ruff from automatically running for this file)

Comment on lines +9 to +11
# file with cell magic not parsed by ruff
"src/resources/jupyter/lang/python/cleanup.py",
"src/resources/jupyter/lang/python/setup.py",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cscheid we already don't process those files as they don't play well with ruff as you guessed. This why they are not formatted in this PR.

@cderv cderv merged commit 7d2b828 into main May 6, 2025
49 checks passed
@cderv cderv deleted the use-ruff-2 branch May 6, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants