Feature: unified light and dark brand #12883
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows specifying light and dark brands in one file, by customizing colors in
colorortypographywithlight:anddark:, e.g.This introduces two brand schemas, "single" and "unified". Hopefully these names are clear; happy to iterate.
brand.lightandbrand.darkonly take single brand.brandtakes a unified brand (either inline or from a file). We split into light and dark brands and everything from that point is the same as before.If there are no dark customizations then the unified brand has no dark mode.
Detecting whether dark mode is enabled is now depends on the resolved brand, looking at
format.renderinstead of justformat.metadata.I think that the same two-schema approach will clarify
brand.logofor dark logo #12341.cc @gadenbuie