check, knitr - Add .exe to binary on Windows for correct check #12887
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bad problem when you run
quartoCLI from another process havingR_HOMEset (like running from an R session): another R version would be used;This solves quarto-dev/quarto-r#204, but also problem on Windows
This is because we append
binandRscriptand test the pathquarto-cli/src/core/resources.ts
Lines 116 to 121 in 84c6cba
We need to add
.exeon Windows if we test path existence.Note: I really would like to backport this as this is a bad issue.