Skip to content

Conversation

@cderv
Copy link
Collaborator

@cderv cderv commented Jun 11, 2025

Related to discussion in

to understand better what is happening.

Follow up to what has been done for R already:

@posit-snyk-bot
Copy link
Collaborator

posit-snyk-bot commented Jun 11, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@cderv cderv merged commit 892fdd4 into main Jun 11, 2025
49 checks passed
@cderv cderv deleted the debug-log-python branch June 11, 2025 11:48
@cscheid
Copy link
Collaborator

cscheid commented Jun 11, 2025

This is good, thanks!

I wonder if we could make it even better by recording the debug() output in a structured format so that we can produce a JSON report like we have for quarto check --json.

@cderv
Copy link
Collaborator Author

cderv commented Jun 11, 2025

Nice idea. The engine binding logic is definitely something we should log better. I'll look at the JSON option.

I made quick improvement to help debug something in a discussion, but definitely needs improvement, and more generic logic for all detection engine. Some improvement needs to be made for Windows detection anyway, so I'll maybe do it before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants