typst: declare brand-logo and brand-logo-images dictionaries #13119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
brand processedData resolves paths in logo.images
gordonwoodhull
force-pushed
the
feature/typst-brand-logo-dictionaries
branch
from
32280e3 to
09308fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also resolve paths in brand
processedData.logo.imagesPulling this code out of
to merge separately.
This opens a couple of very minor design questions which we could address later:
brand.meta, which we don't use, be exposed as Typst data in the same way?brand.typographyis exposed via Pandoc metadata, and ingested bytypst-show.typ, and that's a different approach which seems more appropriate for that content. Is there a principle?