Skip to content

Conversation

gordonwoodhull
Copy link
Contributor

The page partial takes page layout and numbering set-rules out of the article() function and puts them at top-level.

It also takes the logo set page background rule, which was previously generated in typst-brand-yaml.lua.

The partial gives users an easier way to customize page and logo options, or combine them with other page background properties.

@posit-snyk-bot
Copy link
Collaborator

posit-snyk-bot commented Jul 23, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@gordonwoodhull gordonwoodhull force-pushed the feature/typst-page-partial branch from 3c64289 to 3fa0bc8 Compare July 23, 2025 17:40
@gordonwoodhull gordonwoodhull requested a review from mcanouil July 23, 2025 17:40
@gordonwoodhull
Copy link
Contributor Author

As proposed by @mcanouil in #13108 (comment), with the minor difference that we don't set page.background if we don't have a logo. (We don't want to remove background that may have been added elsewhere.)

move page stuff out of article() function
move logo stuff out of typst-brand-yaml.lua
@gordonwoodhull gordonwoodhull force-pushed the feature/typst-page-partial branch from 3fa0bc8 to a35ff7d Compare July 23, 2025 19:33
@gordonwoodhull gordonwoodhull merged commit 75fbfd0 into main Jul 23, 2025
51 checks passed
@gordonwoodhull gordonwoodhull deleted the feature/typst-page-partial branch July 23, 2025 19:59
@gordonwoodhull gordonwoodhull added this to the v1.8 milestone Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants