Use multiple integrity attributes for require.min.js #13184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We observed that VS Code and Chrome each compute different integrity values. This is apparently expected behavior in some cases: https://claude.ai/share/7c3437d9-664e-4e82-aa92-6bdf37ff9025 Possible mitigations include: 1) Define multiple values for `integrity` (what we did here); or 2) Remove the `integrity` attribute if you trust the host and are running over https. 3) Bundle our own version of require.js
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
|
Thanks! That failing test is bewildering to me:
I'm going to merge this anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We observed that VS Code and Chrome each compute different integrity values. This is apparently expected behavior in some cases: https://claude.ai/share/7c3437d9-664e-4e82-aa92-6bdf37ff9025
Possible mitigations include:
integrity(what we did here); orintegrityattribute if you trust the host and are running over https; or