Skip to content

Conversation

gordonwoodhull
Copy link
Contributor

fixes #12643

When populating brand processedData with logo paths, we need to skip URLs.

Later processing does this already, as demonstrated by tests.

@posit-snyk-bot
Copy link
Collaborator

posit-snyk-bot commented Aug 11, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@gordonwoodhull
Copy link
Contributor Author

Hmm, a lot of errors in code we haven't changed recently, prob "collateral evolution" 😉

error: Uncaught (in promise) SyntaxError: Invalid flags supplied to RegExp constructor 'l'
const kNamedFileRegex = RegExp(kNamedFilePattern, "l");
                        ^
    at RegExp (<anonymous>)
    at file:///home/runner/work/quarto-cli/quarto-cli/src/project/types/website/util/discover-meta.ts:18:25
Error: Process completed with exit code 1.

@gordonwoodhull
Copy link
Contributor Author

Closing this because GHA refuses to run the tests correctly.

Replaced by #13214 (which probably won't do any better).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect rendering of URL logos supplied to _brand.yml when rendering to HTML

2 participants