Skip to content

Conversation

gordonwoodhull
Copy link
Contributor

fixes #12643

When populating brand processedData with logo paths, we need to skip URLs.

Later processing does this already, as demonstrated by tests.

Replaces #13214 — let's see if copying a utility function instead of importing it avoids this error.

@posit-snyk-bot
Copy link
Collaborator

posit-snyk-bot commented Aug 13, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@gordonwoodhull
Copy link
Contributor Author

Yes! It does appear that the weird error

error: Uncaught (in promise) SyntaxError: Invalid flags supplied to RegExp constructor 'l'
const kNamedFileRegex = RegExp(kNamedFilePattern, "l");
                        ^
    at RegExp (<anonymous>)
    at file:///home/runner/work/quarto-cli/quarto-cli/src/project/types/website/util/discover-meta.ts:18:25
Error: Process completed with exit code 1.

was caused by a questionable export and/or import, specifically exporting isExternalPath from

  • src/project/types/website/website-navigation.ts

and importing to

  • src/core/brand/brand.ts

I'd be glad to investigate further if anyone else finds this interesting. But I'll wait until tomorrow on that. 😉

@gordonwoodhull gordonwoodhull merged commit 7e02521 into main Aug 13, 2025
50 of 53 checks passed
@gordonwoodhull gordonwoodhull deleted the bugfix/13193d branch August 13, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect rendering of URL logos supplied to _brand.yml when rendering to HTML

2 participants