implement @font-face for file-based brand.yml fonts #13280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
gordonwoodhull
force-pushed
the
bugfix/12501
branch
from
f071ba7 to
4505a62
Compare
Contributor
Author
|
The smoke tests were enough to trigger a path issue on Windows — looks like we go in and copy any font files referenced. SCSS is of these places where we need to use either forward slashes or double backslashes (so I chose forward slashes). So I'm pretty confident about this change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12501
brand-font-filemaps directly to a simple@font-facedeclaration with only one font resource per@font-faceand noformat()This adds smoke tests but we don't currently have a good way to directly test SCSS, so nothing is verified.