-
Notifications
You must be signed in to change notification settings - Fork 391
publish, connect - fix tar bundle creation using temp context #13405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
|
While testing this, bundles creation is ok but there is an issue in how Posit connect deploy the bundle. Somehow, the mimetype of the file is not correctly guessed it seems Is there something happening with this new tar library ? |
|
That's possible! One way to check is to create a tar file from the old version and compare it to the one created by the new version. |
|
I found it, we've regressed on
So I'll put back the normalization lost in refactoring. |
…r Connect deploys std/tar will create folders based on file paths used, but it requires using / and not \\ in path. This is a problem on Windows, where the path separator is \\. This commit normalize the path to use / instead of \\ when creating the tar.gz file for Connect deploys.
ffb7459 to
64656b7
Compare
It has been backported to 1.8
|
@cderv we should try to coordinate with the posit connect folks to have a scheduled integration test in CI. |
|
Yes 💯 I already asked and they may have some solution we could run in CI. I'll update when I have something |
This PR fix the tar creation in bundle for connect.
The new function was not correctly handling filepaths, as the output tar is not in a relative place compared to the file to include, and also the tar creation command needs to be run in the same place as the file itself to be found
So now full path is used for files to include