Skip to content

Conversation

bruvellu
Copy link
Contributor

Description

This PR fixes the uncentered play button in videos rendered from cross-reference divs by adding a missing style class.

Addresses #13411.

Checklist

I have (if applicable):

  • filed a contributor agreement.
  • referenced the GitHub issue this PR closes
  • updated the appropriate changelog in the PR
  • ensured the present test suite passes
  • added new tests
  • created a separate documentation PR in Quarto's website repo and linked it to this PR

@posit-snyk-bot
Copy link
Collaborator

posit-snyk-bot commented Sep 24, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@cscheid
Copy link
Collaborator

cscheid commented Sep 24, 2025

Thank you! Can you add a changelog entry to news/changelog-1.9.md? You can use https://github.com/quarto-dev/quarto-cli/blob/main/news/changelog-1.8.md as an example.

@cscheid
Copy link
Collaborator

cscheid commented Sep 24, 2025

I don't think we need a contributor agreement for a small change like this, although we'd love for you to send one so you're ready when you make a larger PR!

@bruvellu
Copy link
Contributor Author

Thank you! Can you add a changelog entry to news/changelog-1.9.md? You can use https://github.com/quarto-dev/quarto-cli/blob/main/news/changelog-1.8.md as an example.

Done!

I don't think we need a contributor agreement for a small change like this, although we'd love for you to send one so you're ready when you make a larger PR!

Cool, I'll check the agreement

@cscheid cscheid merged commit 0252e42 into quarto-dev:main Sep 24, 2025
51 checks passed
@cscheid
Copy link
Collaborator

cscheid commented Sep 24, 2025

Merged! I'll make a few minor changes so we don't forget to acknowledge you in the next release. Thanks for the contribution, we very much appreciate it! 🎉

@bruvellu
Copy link
Contributor Author

Thanks! Will the original issue be automatically closed upon the 1.9 release?

@cscheid
Copy link
Collaborator

cscheid commented Sep 25, 2025

We close them right away, and often automatically. I thought "addresses #number" worked in github, but it doesn't. I'll do it now. Thanks for the reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants