bugfix: minimal: true would assert when combined with brand #13439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #13383 v1.7 introduced this code implementing the light, dark, light stylesheet trick for syntax highlighting css. it should not try to do this if there are no stylesheets! we did not see the bug trigger until v1.8 which treats brand data as possibly implementing both light and dark decided when we see theme.
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
|
Uncovered #13450 while testing this. This code shouldn't be hit, but for now let's make sure it doesn't crash. I'll proceed with backport and changelog on 1.8. |
gordonwoodhull
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13383
v1.7 introduced this code implementing the light, dark, light stylesheet trick for syntax highlighting css.
it should not try to do this if there are no stylesheets!
we did not see the bug trigger until v1.8 which treats brand data as possibly implementing both light and dark
decided when we see theme
PR for CI; want to investigate a little further whether this means we're passing around
hasDark/hasDarkStylesthat are always true.