Correctly check for sidebar.logo in EJS template #13507
Draft
+74
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
…rties So `sidebar.logo` is never undefined - it may have light or dark undefined, but the object itself exists.
cderv
force-pushed
the
fix/nologo-sidebar
branch
from
91be50e to
9c645b4
Compare
|
While trying to add some tests, I am now wondering how we are supposed to pass logo when we do hybrid navigation: https://quarto.org/docs/websites/website-navigation.html#hybrid-navigation
🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sidebar.logo is now normalized as an object with light and dark properties
So
sidebar.logois never undefined - it may have light or dark undefined, but the object itself exists.fix #13506