Add support for icon=false in typst callout #13590
Merged
+77
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
|
LGTM! Surprises me that we support false but not values here, but that’s how it is across formats. 🤷♂️ |
gordonwoodhull
approved these changes
Oct 23, 2025
Collaborator
Author
|
Thanks for the review !
What do you mean? Values as choosing the icon to use for a callout? I guess this relates to Custom Callout supports in a way, and we should maybe work on this wished feature: To be discussed there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13555
This PR brings support for
icon=falsein callouts(centering problem for referenced callouts is to be dealt with in #12803)
@gordonwoodhull could you review this PR for thoughts maybe ? Thank you.