Fix detection of LuaTeX-ja missing file errors #13618
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuaTeX-ja errors use "File" with capital F in error messages like: "! LuaTeX-ja error: File 'jfm-zh_CN.lua' not found." Updated regex pattern to match both "file" and "File" by using [fF]ile character class. Added test case to verify detection. Fixes rstudio/tinytex-releases#49
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Collaborator
Author
|
Some playwright tests are failling somehow... 🤔 I don't this change has impact. I'll check locally. |
Collaborator
Author
|
They are passing so it must be something else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LuaTeX-ja errors use "File" with capital F in error messages like: "! LuaTeX-ja error: File 'jfm-zh_CN.lua' not found."
Updated regex pattern to match both "file" and "File" by using [fF]ile character class. Added test case to verify detection.
Fixes rstudio/tinytex-releases#49