Update journal extensions before running format extension tests #13650
+9,971
−1,042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
The static journal extensions (acs, elsevier) in tests were frozen at Sept 2023 versions, causing issues with current Quarto including PDF rendering hangs. Modified render-format-extension.test.ts to update extensions from quarto-journals GitHub repos before running tests. Falls back to committed versions on network failure for CI reliability. Updated committed extension files to current versions: - acs: Added fancy-text and latex-environment dependencies - elsevier: Added Lua filter and restructured partials Tests verify format rendering (HTML/PDF/variants) while extension-render-journals.test.ts tests template scaffolding. Both files serve different purposes. Related to #13647
The acs and elsevier journal extensions copy .bst and .cls files to the test directory during rendering. These files were not being cleaned up by teardown, leaving artifacts after test runs.
Added comment explaining that committed extension files serve as fallback and don't need frequent updates since tests fetch latest versions. Recommends updating committed files when extension-related issues occur to document working versions.
cderv
force-pushed
the
tests/update-journal-extensions
branch
from
2e6e1fa to
e5ddc4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static journal extensions (acs, elsevier) in tests were frozen at
Sept 2023 versions, causing issues with current Quarto including PDF
rendering hangs.
Modified render-format-extension.test.ts to update extensions from
quarto-journals GitHub repos before running tests. Falls back to
committed versions on network failure for CI reliability.
Updated committed extension files to current versions:
Tests verify format rendering (HTML/PDF/variants) while
extension-render-journals.test.ts tests template scaffolding.
Both files serve different purposes.
Related to #13647
Should help solve #13643