Skip to content

fix: link-external-newwindow: true not respected by default listing #9469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

fix: link-external-newwindow: true not respected by default listing #9469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
64d2861
fix: `link-external-newwindow: true` not respected by default listing
mcanouil Apr 24, 2024
51d502b
chore: add item to changelog
mcanouil Apr 24, 2024
b652ee8
Merge branch 'main' into fix/issue9468
mcanouil Apr 27, 2024
fd183f8
chore: revert addition of changelog entry
mcanouil Feb 1, 2025
11574fe
Merge branch 'main' into fix/issue9468
mcanouil Feb 1, 2025
dc08084
chore: add back log entry
mcanouil Feb 1, 2025
d813279
fix: add rule to hide external icon in default listing
mcanouil Feb 1, 2025
07e9052
Merge branch 'main' into fix/issue9468
mcanouil Mar 8, 2025
f39c371
Merge branch 'main' into fix/issue9468
mcanouil Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/changelog-1.7.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ All changes included in 1.7:
- ([#8238](https://github.com/quarto-dev/quarto-cli/issues/8238)): Listing categories are now sorted case-insensitively.
- ([#10501](https://github.com/quarto-dev/quarto-cli/issues/10501)): Improve documentation of `repo-actions` option.
- ([#11701](https://github.com/quarto-dev/quarto-cli/issues/11701)): Wrap HTML emitted by EJS templates in `{=html}` blocks to avoid memory blowup issues with Pandoc's parser.
- ([#9468](https://github.com/quarto-dev/quarto-cli/issues/9468)): Respect `link-external-newwindow: true` in "default" type listing.
- ([#12134](https://github.com/quarto-dev/quarto-cli/issues/12134)): Forward `logo.small` images in `_brand.yml` files to a website `favicon`.

### `blog`
Expand Down
4 changes: 4 additions & 0 deletions src/resources/formats/html/_quarto-rules-link-external.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ a.external:after:hover {
cursor: pointer;
}

.quarto-listing-default a.external:after {
content: none;
}

.quarto-ext-icon {
display: inline-block;
font-size: 0.75em;
Expand Down
10 changes: 5 additions & 5 deletions src/resources/projects/website/listing/item-default.ejs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ print(`<div class="metadata-value listing-${field}">${listing.utilities.outputLi
<% if (fields.includes('image')) { %>

```{=html}
<div class="thumbnail"><a href="<%- item.path %>" class="no-external">
<div class="thumbnail"><a href="<%- item.path %>">
<% if (item.image) { %>
<%= listing.utilities.img(itemNumber, item.image, "thumbnail-image", item['image-alt'], item['image-lazy-loading'] ?? listing['image-lazy-loading']) %>
<% } else { %>
Expand All @@ -55,9 +55,9 @@ print(`<div class="metadata-value listing-${field}">${listing.utilities.outputLi
::: {.body}

<% if (fields.includes('title')) { %>
<h3 class="no-anchor listing-title"><a href="<%- item.path %>" class="no-external"><%= item.title %></a></h3>
<h3 class="no-anchor listing-title"><a href="<%- item.path %>"><%= item.title %></a></h3>
<% if (fields.includes('subtitle')) { %>
<div class="listing-subtitle"><a href="<%- item.path %>" class="no-external"><%= item.subtitle %></a></div>
<div class="listing-subtitle"><a href="<%- item.path %>"><%= item.subtitle %></a></div>
<% } %>
<% } %>

Expand All @@ -76,7 +76,7 @@ print(`<div class="metadata-value listing-${field}">${listing.utilities.outputLi
<% if (fields.includes('description')) { %>

```{=html}
<div class="delink listing-description"><a href="<%- item.path %>" class="no-external">
<div class="delink listing-description"><a href="<%- item.path %>">
```

<%= item.description %>
Expand All @@ -92,7 +92,7 @@ print(`<div class="metadata-value listing-${field}">${listing.utilities.outputLi
::: {.metadata}

```{=html}
<a href="<%- item.path %>" class="no-external">
<a href="<%- item.path %>">
```

<% if (fields.includes('date') && item.date) { %>
Expand Down
Loading