Skip to content

Add 3x extensions #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cderv merged 2 commits into from
Dec 5, 2024
+20 −1
Merged

Add 3x extensions #1497

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a61a1b7
Add 3x extensions
coatless Nov 29, 2024
f29d214
Reorg; drop `bluesky-comments`
coatless Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions docs/extensions/listings/shortcodes-and-filters.yml
View file
Open in desktop
Copy link
Collaborator

@cderv cderv Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With new work on documentation for 1.6 I tried to ordered the extension by name. It is supposed to be visible, by I know this changed compated to before where it was in order.

Could you just move in the right place colab and tabby ?

Thanks !

Copy link
Contributor Author

@coatless coatless Nov 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll also add in stamp.

Copy link
Contributor Author

@coatless coatless Nov 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in f29d214.

Original file line number Diff line number Diff line change
Expand Up @@ -521,3 +521,21 @@
path: https://github.com/andrewheiss/quarto-wordcount
author: '[Andrew Heiss](https://github.com/andrewheiss/)'
description: Quarto extension for calculating accurate word counts

- name: tabby
path: https://github.com/coatless-quarto/tabby
author: '[James Joseph Balamuta](https://github.com/coatless/)'
description: >
Quarto Extension for Automatic Language Tabs
- name: bluesky-comments
path: https://github.com/coatless-quarto/bluesky-comments
author: '[James Joseph Balamuta](https://github.com/coatless/)'
description: >
Quarto Shortcode Extension to Embed Comments from Bluesky
Copy link
Collaborator

@cderv cderv Nov 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am seing now that @gadenbuie already listed his in #1491
We now have two extensions with the same name in the list.

I saw thread continued on bluesky at https://bsky.app/profile/grrrck.xyz/post/3lbwos6y4c227

this is a really good extension and this makes me think as you seem to be willing to both work together, that we should have one with best of both. What about keeping only one extension for this called bluseky-comments and "merge" your feature ?
I would offer to have it as quarto-ext/bluesky-comments at @quarto-ext. We could make both of you maintainer for this extension in the @quarto-ext org. And we could then list as an official option through an extension in https://quarto.org/docs/output-formats/html-basics.html#commenting with other commenting solution

What do you think ?

Copy link
Contributor Author

@coatless coatless Nov 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, can we just list it along side? I can just use quarto-bluesky-comments or switch to quarto-bluesky. I'm planning on adding a few other items outside of comments as time progress.

If not, no worries. I'll drop it from the PR.

Copy link
Collaborator

@cderv cderv Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not, no worries. I'll drop it from the PR.

Don't drop it - we can list both. I don't think the name will cause problem in the table.

I was just trying to offer a solution to move forward to only have one extension for this feature. I'm quite confident @gadenbuie would work with you, starting from your version. It would be really cool to have this feature a part of options for https://quarto.org/docs/output-formats/html-basics.html#commenting and so having a dedicated extension to it seems nice !

switch to quarto-bluesky. I'm planning on adding a few other items outside of comments as time progress.

If you have some more broad plans for bluesky support, I can understand you don't want a scoped extension. What do you have in mind out of curiosity ?

Copy link
Contributor Author

@coatless coatless Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cderv are you okay if I add you as a maintainer and let you move it over into quarto-ext?

Feature-wise, off the top of my head:

More as I explore the public API.

Copy link
Contributor

@gadenbuie gadenbuie Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the bluesky comments consolidation conversation over in https://github.com/coatless-quarto/bluesky-comments/issues/3.

@coatless I'd love to collaborate but I'd also completely understand if you'd like to take your extension in other directions beyond comments.

Copy link
Contributor Author

@coatless coatless Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gadenbuie will do; no worries on that. Trying to quickly answer @cderv in the midst of fall break being over.

Though, could gently move that repo over? The longer it sits, the more URLs might get setup to point to it. Easier to announce "Better extension" please bookmark blank. 😉

- name: colab
path: https://github.com/coatless-quarto/colab
author: '[James Joseph Balamuta](https://github.com/coatless/)'
description: >
Quarto Extension to Transform Quarto Documents into Google Colaboratory Notebooks
Loading