Skip to content

Conversation

@cderv
Copy link
Collaborator

@cderv cderv commented Oct 10, 2025

Goes with

Document plausible-analytics new key by added a part in same place as Google Analytics.

  • It adds a new Analytics section
  • It puts Plausible before Google Analytics to show we prefer it in a way
  • It links to the step you need to do to get your snippet

@cderv cderv changed the base branch from main to prerelease October 10, 2025 10:35
@cderv cderv force-pushed the plausible-analytics branch from fe84dc6 to 3f6e9ac Compare October 10, 2025 10:38
@cderv cderv requested a review from cwickham October 10, 2025 10:39
@github-actions github-actions bot temporarily deployed to pull request October 10, 2025 10:45 Inactive
@github-actions
Copy link
Contributor

📝 Preview Deployment

🔍 Full site preview: https://deploy-preview-1805.quarto.org

🔄 Modified Documents

Copy link
Collaborator

@cwickham cwickham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let me know if you want me to a take another look if you implement path:

Comment on lines +230 to +238
``` yaml
website:
plausible-analytics: |
<script async src="https://plausible.io/js/pa-XXXXXX.js"></script>
<script>
window.plausible=window.plausible||function(){(plausible.q=plausible.q||[]).push(arguments)},plausible.init=plausible.init||function(i){plausible.o=i||{}};
plausible.init()
</script>
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see getting the right indentation will be a source of problems for users...another reason to offer a path entrypoint.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added support for path in quarto-dev/quarto-cli#13524

Can you review the modified version of this PR ?

Thank you !

Co-authored-by: Charlotte Wickham <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request October 13, 2025 12:55 Inactive
@github-actions
Copy link
Contributor

📝 Preview Deployment

🔍 Full site preview: https://deploy-preview-1805.quarto.org

🔄 Modified Documents

@cderv cderv requested a review from cwickham October 13, 2025 15:51
@github-actions github-actions bot temporarily deployed to pull request October 13, 2025 15:57 Inactive
@github-actions
Copy link
Contributor

📝 Preview Deployment

🔍 Full site preview: https://deploy-preview-1805.quarto.org

🔄 Modified Documents

@cderv
Copy link
Collaborator Author

cderv commented Oct 14, 2025

I merged

So waiting for your last review about the new path option.

Copy link
Collaborator

@cwickham cwickham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cderv cderv merged commit 74f8b9e into prerelease Oct 15, 2025
4 checks passed
@cderv cderv deleted the plausible-analytics branch October 15, 2025 10:01
cderv added a commit that referenced this pull request Oct 16, 2025
this covers plausible and google analytics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants