-
Notifications
You must be signed in to change notification settings - Fork 980
Document plausible-analytics new config
#1805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fe84dc6 to
3f6e9ac
Compare
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-1805.quarto.org 🔄 Modified Documents |
cwickham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Let me know if you want me to a take another look if you implement path:
| ``` yaml | ||
| website: | ||
| plausible-analytics: | | ||
| <script async src="https://plausible.io/js/pa-XXXXXX.js"></script> | ||
| <script> | ||
| window.plausible=window.plausible||function(){(plausible.q=plausible.q||[]).push(arguments)},plausible.init=plausible.init||function(i){plausible.o=i||{}}; | ||
| plausible.init() | ||
| </script> | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see getting the right indentation will be a source of problems for users...another reason to offer a path entrypoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added support for path in quarto-dev/quarto-cli#13524
Can you review the modified version of this PR ?
Thank you !
Co-authored-by: Charlotte Wickham <[email protected]>
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-1805.quarto.org 🔄 Modified Documents |
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-1805.quarto.org 🔄 Modified Documents |
|
I merged So waiting for your last review about the new |
cwickham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
this covers plausible and google analytics
Goes with
Document
plausible-analyticsnew key by added a part in same place as Google Analytics.