Skip to content

fix: Use text area for alternative text and captions (visual editor) #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
+47 −26
Open

fix: Use text area for alternative text and captions (visual editor) #644

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7e45474
fix: use text box instead of input for alt-text
mcanouil Jan 20, 2025
615dc1e
fix: use resize instead of setting height
mcanouil Jan 20, 2025
1a82885
refactor: use text area for caption
mcanouil Jan 20, 2025
f4bf877
refactor: text area for table caption
mcanouil Jan 20, 2025
edb703c
refactor: use text box for caption in table
mcanouil Jan 21, 2025
9a60b87
refactor: use text box for caption in callout
mcanouil Jan 21, 2025
b992223
chore: update changelog entry
mcanouil Jan 21, 2025
f67eb20
fix(changelog): correct pr number
mcanouil Jan 21, 2025
a49c9b4
Merge branch 'main' into fix/alt-text-box
mcanouil Mar 3, 2025
2ea2eed
Merge branch 'main' into fix/alt-text-box
mcanouil Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apps/vscode/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## 1.119.0 (unreleased)

- Visual Editor: "Inset image" command now uses a text box for the alternative text. (<https://github.com/quarto-dev/quarto/pull/599>)

## 1.118.0 (Release on 2024-11-26)

- Provide F1 help at cursor in Positron (<https://github.com/quarto-dev/quarto/pull/599>)
Expand Down
11 changes: 5 additions & 6 deletions packages/editor-ui/src/dialogs/edit-image.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ import {
useId,
RadioGroup,
Label,
Radio
Radio,
Textarea
} from "@fluentui/react-components";

import { ModalDialog, ModalDialogTabList, showValueEditorDialog} from "ui-widgets";
Expand Down Expand Up @@ -162,10 +163,11 @@ const imagePanel =

{alt !== undefined
? <Field label={t("Alternative text")}>
<Input
value={alt}
<Textarea
value={alt}
onChange={(_ev, data) => setAlt(data.value)}
placeholder={t("(Optional)")}
style={{ height: "100px" }}
/>
</Field>
: null
Expand Down Expand Up @@ -288,6 +290,3 @@ const useStyles = makeStyles({
gridRowGap: tokens.spacingVerticalS,
}
})



Loading