Turn off visual mode completions in Positron

apps/vscode/CHANGELOG.md

@@ -3,6 +3,7 @@
 ## 1.122.0 (unreleased)
 
 - Change controls on Positron editor action bar and fix "Render on Save" behavior (<https://github.com/quarto-dev/quarto/pull/706>).
+- Turn off completions in visual mode in Positron, as a temporary stopgap until we can invest more in LSP features in the visual editor (<https://github.com/quarto-dev/quarto/pull/710>).
 
 ## 1.121.0 (Release on 2025-05-02)
 

apps/vscode/src/providers/editor/codeview.ts

@@ -45,6 +45,7 @@ import {
   kCodeViewGetCompletions,
 } from "editor-types";
 
+import { hasHooks } from "../../host/hooks";
 import { embeddedLanguage } from "../../vdoc/languages";
 import { virtualDocForCode } from "../../vdoc/vdoc";
 import { vdocCompletions } from "../../vdoc/vdoc-completion";
@@ -83,6 +84,7 @@ export function vscodeCodeViewServer(_engine: MarkdownEngine, document: TextDocu
 
         // see if we have an embedded langaage
         const language = embeddedLanguage(context.language);
+
         if (language) {
 
           // if this is a yaml comment line then call the lsp
@@ -91,7 +93,11 @@ export function vscodeCodeViewServer(_engine: MarkdownEngine, document: TextDocu
             return lspCellYamlOptionsCompletions(context, lspRequest);
 
             // otherwise delegate to vscode completion system
-          } else {
+            // is this in Positron? If so, no completions
+            // TODO: fix LSP issues for visual editor in Positron:
+            // https://github.com/posit-dev/positron/issues/1805
+          }
+          if (!hasHooks()) {
             const vdoc = virtualDocForCode(context.code, language);
             const completions = await vdocCompletions(
               vdoc,
@@ -108,12 +114,11 @@ export function vscodeCodeViewServer(_engine: MarkdownEngine, document: TextDocu
               isIncomplete: false
             };
           }
-        } else {
-          return {
-            items: [],
-            isIncomplete: false
-          };
         }
+        return {
+          items: [],
+          isIncomplete: false
+        };
       }
     },
     async codeViewPreviewDiagram(state: DiagramState, activate: boolean) {