-
Notifications
You must be signed in to change notification settings - Fork 44
allow '=' in values of pandoc key=value pairs #814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cscheid
merged 5 commits into
quarto-dev:main
from
kevinushey:bugfix/pandoc-key-attr-equals-handling
Sep 11, 2025
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # Testing equals signs in attribute values | ||
|
|
||
| This test document validates that equals signs in attribute values are handled correctly. | ||
|
|
||
| ## Basic examples | ||
|
|
||
| - Basic link with equals in value: [Link text](https://example.com){key=value=with=equals} | ||
|
|
||
| - Link with URL parameter: [Query link](https://example.com?param=value){.class key=query=param} | ||
|
|
||
| - Span with complex value: [Span text]{#id .class key=complex=value} | ||
|
|
||
| ## More complex examples | ||
|
|
||
| - CSS style with equals: [Styled text]{style=color:red;font-size=12px} | ||
|
|
||
| - Math expression value: [Math formula]{formula=E=mc^2} | ||
|
|
||
| - Code with equals: `code sample`{lang=c++ key=value=val} | ||
|
|
||
| ## Code blocks | ||
|
|
||
| ```{python key=value=equals} | ||
| print("Testing equals in attribute values") | ||
| ``` | ||
|
|
||
| ```{r eval=1+1=2} | ||
| print("R code with equals in attributes") | ||
| ``` | ||
|
|
||
| ## Div with attributes | ||
|
|
||
| :::{#div-id key=value=with=multiple=equals} | ||
| This is a div with multiple equals signs in attribute values. | ||
| ::: | ||
|
|
||
| ## Image with equals signs | ||
|
|
||
| {width=50% height=30% key=value=equals} | ||
|
|
||
| ## Table with equals signs | ||
|
|
||
| | Col1 | Col2 | | ||
| |------|------| | ||
| | A | B | | ||
| | C | D | | ||
|
|
||
| : Table caption {#tbl-id tbl-colwidths="[50,50]" key=value=with=equals} |
48 changes: 48 additions & 0 deletions
48
apps/vscode/src/test/examples/generated_snapshots/roundtripped-attr-equals.qmd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # Testing equals signs in attribute values | ||
|
|
||
| This test document validates that equals signs in attribute values are handled correctly. | ||
|
|
||
| ## Basic examples | ||
|
|
||
| - Basic link with equals in value: [Link text](https://example.com){key="value=with=equals"} | ||
|
|
||
| - Link with URL parameter: [Query link](https://example.com?param=value){.class key="query=param"} | ||
|
|
||
| - Span with complex value: [Span text]{#id .class key="complex=value"} | ||
|
|
||
| ## More complex examples | ||
|
|
||
| - CSS style with equals: [Styled text]{style="color:red;font-size=12px"} | ||
|
|
||
| - Math expression value: [Math formula]{formula="E=mc^2"} | ||
|
|
||
| - Code with equals: `code sample`{lang="c++" key="value=val"} | ||
|
|
||
| ## Code blocks | ||
|
|
||
| ```{python key=value=equals} | ||
| print("Testing equals in attribute values") | ||
| ``` | ||
|
|
||
| ```{r eval=1+1=2} | ||
| print("R code with equals in attributes") | ||
| ``` | ||
|
|
||
| ## Div with attributes | ||
|
|
||
| ::: {#div-id key="value=with=multiple=equals"} | ||
| This is a div with multiple equals signs in attribute values. | ||
| ::: | ||
|
|
||
| ## Image with equals signs | ||
|
|
||
| {width="50%" height="30%" key="value=equals"} | ||
|
|
||
| ## Table with equals signs | ||
|
|
||
| | Col1 | Col2 | | ||
| |------|------| | ||
| | A | B | | ||
| | C | D | | ||
|
|
||
| : Table caption {#tbl-id tbl-colwidths="\[50,50\]" key=value=with=equals} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Realized post-hoc that I should probably check if the line here actually has an
=?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea I suppose so! like
if (idx === -1) return [line, '']; else { bla }