Fix/vscode format cell continued #818
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edit: this PR is obsolete now, the changes have been moved over to #754
A copy of @lionel-'s branch for PR #754 which addresses issue #745, but:
Excuse me for copying the branch&PR to a new branch&PR, but I didn't feel comfortable force pushing to the original.
This is still a WIP. I don't currently know how to interpret the test results: When I ran this test with the main fix by @lionel- reverted (the one that adds a newline), the formatter does not seem to run at all... I don't understand why.
note: @juliasilge showed me this PR that creates a minimal formatter for reference.