Add test to check that the extension does not cause issues with non-qmd files #850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great. Thank you! |
cscheid
approved these changes
Oct 14, 2025
juliasilge
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is added to prevent situations like #845 in which code was added to the extension that caused non-qmd text files to be closed and re-opened in the visual editor (very bad).
The test checks that a
.luafile can be opened, edited, and saved and afterwards is still open as the active editor in VSCode. I "red-light/green-light"'d the test (made sure it failed when I checked out v1.125, the version with the problem, and passed when I checked out v1.126, the version with the fix).We could make this test catch other similar types of issues, but this seems like the simplest way to catch issues like #845 where saving a non-qmd file messes with the active VSCode editor.