Skip to content

fix: regex for detecting preview url #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2025
+2 −1
Merged

fix: regex for detecting preview url #853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6777a8
fix: regex for detecting preview url
daniel-eder Oct 18, 2025
1dd4041
Add changelog entry
vezwork Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/vscode/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## 1.127.0 (Unreleased)

- Added a new setting `quarto.useBundledQuartoInPositron` to prefer the Quarto CLI bundled with Positron when available. This setting has precedence _between_ `quarto.path` and `quarto.usePipQuarto`, and has no effect outside of Positron (<https://github.com/quarto-dev/quarto/pull/841>).
- Fixed a bug where previewing showed "Not Found" on Quarto files with spaces in the name in subfolders of projects (<https://github.com/quarto-dev/quarto/pull/853>).

## 1.126.0 (Release on 2025-10-08)

Expand Down
2 changes: 1 addition & 1 deletion apps/vscode/src/providers/preview/preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ class PreviewManager {
// capture preview command url and preview url
this.previewCommandUrl_ = match[1];
const browseMatch = this.previewOutput_.match(
/(Browse at|Listening on) (https?:\/\/[^\n]*)/
/(Browse at|Listening on)\s+(https?:\/\/[^\n]*)/
);
if (browseMatch) {
// earlier versions of quarto serve didn't print out vscode urls
Expand Down