Feature - Bulk loaders #1344
Open
Feature - Bulk loaders #1344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Beznos <[email protected]>
- Finalized method on all scheduler Impls Signed-off-by: Mark Beznos <[email protected]>
Signed-off-by: Mark Beznos <[email protected]>
- Started work on bulk loader for triggers Signed-off-by: Mark Beznos <[email protected]>
Signed-off-by: Mark Beznos <[email protected]>
- added `selectTriggersForCalendarV2` in `DriverDelegate` - added `useEnhancedStatements` in `JobStoreSupport` - Updated `containsColumnNames` - Extended tests Signed-off-by: Mark Beznos <[email protected]>
Signed-off-by: Mark Beznos <[email protected]>
Signed-off-by: Mark Beznos <[email protected]>
Next: add tests, finish Signed-off-by: Mark Beznos <[email protected]>
Signed-off-by: Mark Beznos <[email protected]>
- Fixed some config issues - removed un-neccesary column prefix Signed-off-by: Mark Beznos <[email protected]>
vibbix
force-pushed
the
feature/bulk-loaders
branch
from
388e544 to
8904229
Compare
|
Excellent! I was actually searching for this ^^ My only suggestion is to avoid using "*" imports |
jhouserizer
added
is:feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new "enhanced" bulk loader for getting jobs and triggers. It also allows preexisting methods to optionally opt-in to this reducing the number of round trips needed for loading a large selection of jobs and triggers.
Changes
List<JobDetail> getJobDetails(GroupMatcher<JobKey> matcher)loadExtendedTriggerPropertiesFromResultSetgetTriggersByJobAndTriggerGroupthat allows batch searching for triggers with Job And Group matchersuseEnhancedStatementsproperty for JDBC job storeChecklist
git commit -son my commits, and submit this code under terms of the Apache 2.0 license and assign copyright to the Quartz project owners(If you're not using command-line, you can use a browser extension )
In submitting this contribution, I agree to the terms of contributing as referred to here:
https://github.com/quartz-scheduler/contributing/blob/main/CONTRIBUTING.md