Fix GitHub Action failures and improve robustness #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add GitHub token support to avoid API rate limiting - Add comprehensive error handling with set -e and error checks - Add architecture detection for x86_64 and ARM64 support - Add detailed debugging output and GitHub Actions error annotations - Create CI workflow to test the action - Update README with usage examples and troubleshooting guide 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Remove duplicate test.yml workflow - Add tests for GitHub token support in existing ci.yml - Add test for specific version with token 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Replace grep-based version check with functional test - Test actual sqruff functionality instead of parsing version output - This approach is more robust and won't break with version format changes 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Author
|
@benfdking this action is failing quite often in our workflow with: This PR should improve it. |
- Add || true to sqruff lint command to prevent CI failure - sqruff lint returns non-zero exit code when it finds linting issues - We just want to verify sqruff runs, not that the SQL passes linting 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Replace sqruff lint with sqruff parse for testing - parse command succeeds if SQL is syntactically valid - More appropriate for testing if sqruff is working correctly - Also add sqruff --help for additional verification 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Keep only --version and --help which should be stable across versions - Avoids failures due to CLI interface changes between versions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements to the
install-sqruff-cli-actionGitHub Action, including improved functionality, better error handling, and updated documentation. The changes focus on adding support for GitHub tokens to handle API rate limits, architecture detection, and enhanced installation verification. Additionally, the documentation has been expanded to include usage examples and troubleshooting tips.Enhancements to functionality:
github-tokeninput to handle GitHub API rate limits during version fetching. This includes a fallback mechanism and error messaging when the API rate limit is exceeded. (action.yml, action.ymlR11-R103)action.yml, action.ymlR11-R103)Improvements to installation process:
action.yml, action.ymlR11-R103)sqruffand ensure the binary is executable. (action.yml, action.ymlR11-R103)Documentation updates:
README.mdto include detailed features, usage examples, input descriptions, troubleshooting tips, and an example workflow for the GitHub Action. (README.md, README.mdL3-R89)Workflow updates:
.github/workflows/ci.yml, .github/workflows/ci.ymlR24-R61)